MOM iOS Sync Engineers - 19 Sept 2017
XIB Strings:
Moving old XIB strings can be somehow important now due to the last problem in uploading our xliff file to POEditor. Generating Xliff file is considered too long in Xcode 8 due to too many strings. In the future, we want to move all the string to Localizable.strings.
Concern:
- Possibility: Upload string untuk product specific? In the future, it is possible to use genstring command to collect strings from specific directory.
- Sometimes hard to find used strings in the project. Perhaps Designer is having more context related to key strings.
- Action Item:
- Talk to Arie whether it is possible to let designer create the key string for engineers.
- Create document to enlist what to do to move XIB strings to Localizable.strings.
Code Review Blocking
- Engineers agree to:
- Push to develop will be blocked 100%. All commit have to be code reviewed.
- Push to release is still acceptable for urgent cases. We encourage to not doing this anymore.
- Enable automated block revision if tests are failing using jenkins
- Rule will be implemented in our repo (develop & release) in 26 September, 2017. We wait for 2.17.0 submission.
Coordinator
React Native
- Possibility to use React Native in 2.19.0.
- In 2.18.0, Infra will include React Native library.
Fat IPA
- Finding: All XIB files have 10 MB big.
- Features are many, it is expected to be big. Infra will check other apps size for threshold.
- Proposal:
- To decrease the usage the XIB files. For simple layout, engineers can use code.
- If engineer find a component duplicated in other products, please let Infra team know. Infra team can create/own that component as standard component.