Announcement regarding currency SDK migration

Background

As enterprise team is currently working on deprecating the old entcurr SDK and migrating it to the new CCP SDK, we from payment team will also migrate the usage the classes that might be needed by product team to unblock them.

Migrated class

We've migrated these classes in monorepo to deprecate the usage of old CurrencyValueHelper and replace it with PaymentCurrencyService

Landed to develop :check: :

CommerceRenderingServiceEmbedded
VoucherItemRenderingBehavior
BaseVoucherItemRenderingBehavior
PaymentFacilityItemRenderingBehavior
PointRedemptionRenderingBehavior
GiftVoucherItemRenderingBehavior
DefaultInvoiceUniqueCodeHelper
CrossSellingBookingRenderingBehavior
CrosssellRenderingComponent

Legacy (soon to be deprecated) classes :check: (landed to develop) :

CommerceClientServiceEmbedded
VoucherItemClientBehavior
BaseVoucherItemClientBehavior
PaymentFacilityItemClientBehavior
PointRedemptionClientBehavior
GiftVoucherItemClientBehavior
CrossSellingBookingClientBehavior

While we already moved those classes, we didn't migrate any of the product-specific related class (*ProductName-RenderingBehavior), we expect each product team to be doing their own migration for those classes.

If you need to initialize the PaymentCurrencyService on your top level, please follow these steps :

Ensure that your top level already has connection to the eciccp as stated here
Get the PaymentCurrencyService and PaymentCurrencyServiceImpl from com.traveloka.pay:payment-currency-api:1.1.38 and com.traveloka.pay:payment-currency-impl:1.1.38 PR
You can also take a look at flight team's implementation, thanks @vivinovia!

FAQ

Q : Why CommerceClientServiceEmbedded is considered as legacy?
A : From payment team's perspective, we see this class as deprecated and we won't maintain those classes anymore, we also already move the usage to CommerceRenderingServiceEmbedded, so please try to migrate your usage as well, you can have a look at this diff (for paypapi) as your reference.
However, we'll also migrate the CommerceRenderingServiceEmbedded and its related classes seeing it might be too much effort for product team to work on both CCP migration and rendering behavior migration at the same time.

Q : I have another class that needs to be migrated by payment team for the CCP SDK enablement
A : Please contact me (@zaky) to have further discussion regarding your needs.